From 992d19cba7af123c54a8a95eaaf09762e5b9d026 Mon Sep 17 00:00:00 2001 From: Jaroslaw Konik Date: Wed, 21 May 2025 21:58:16 +0200 Subject: [PATCH] fix tests --- assets/tests/rhai/pass_vec3_to_script.rhai | 4 +++- src/runtimes/rhai.rs | 6 +++--- src/runtimes/ruby.rs | 3 ++- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/assets/tests/rhai/pass_vec3_to_script.rhai b/assets/tests/rhai/pass_vec3_to_script.rhai index 2c8a176..0afb1c2 100644 --- a/assets/tests/rhai/pass_vec3_to_script.rhai +++ b/assets/tests/rhai/pass_vec3_to_script.rhai @@ -1,5 +1,7 @@ fn test_func(vec3) { if type_of(vec3) != "Vec3" { throw() } - // TODO: assert x,y,z + if vec3.x != 1.5 { throw() } + if vec3.y != 2.5 { throw() } + if vec3.z != -3.5 { throw() } mark_success(); } diff --git a/src/runtimes/rhai.rs b/src/runtimes/rhai.rs index 31faeda..09eb02e 100644 --- a/src/runtimes/rhai.rs +++ b/src/runtimes/rhai.rs @@ -236,9 +236,9 @@ impl Default for RhaiRuntime { .register_fn("new_vec3", |x: f64, y: f64, z: f64| { BevyVec3(Vec3::new(x as f32, y as f32, z as f32)) }) - .register_get("x", |vec: &mut Vec3| vec.x as f64) - .register_get("y", |vec: &mut Vec3| vec.y as f64) - .register_get("z", |vec: &mut Vec3| vec.z as f64); + .register_get("x", |vec: &mut BevyVec3| vec.x() as f64) + .register_get("y", |vec: &mut BevyVec3| vec.y() as f64) + .register_get("z", |vec: &mut BevyVec3| vec.z() as f64); #[allow(deprecated)] engine.on_def_var(|_, info, _| Ok(info.name != "entity")); diff --git a/src/runtimes/ruby.rs b/src/runtimes/ruby.rs index da00a42..a4fe595 100644 --- a/src/runtimes/ruby.rs +++ b/src/runtimes/ruby.rs @@ -1,5 +1,6 @@ // TODO: install with CC=clang rbenv install 3.4.3 -// TODO: adjust rhai examples and docs or maybe more rhai changes to different PR +// TODO: adjust rhai examples and docs or maybe more rhai changes to different PR or even better +// find a better way to test them(dont wrap, generic bevy etc) use std::{ collections::HashMap,